CUMULUS-3682 -- Update @cumulus/message.Granule to handle missing values in CMR metadata #3865
+116
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds logic in convertDateToISOStringSettingNull to - set '' as an expected null if encountered in any of the granule temporal fields handled by the Granules methods. - Handle explicit undefined values by returning them rather than attempting to date convert them (the error case for this ticket) This update should be compatible with api granule write logic in that it's preserving the intent of implicit undefined values while allowing for explicit undefineds that weren't originally part of the expected typing coming from the CMR metadata spec.
npauzenga
reviewed
Jan 27, 2025
| @@ -46,7 +46,7 @@ export type ApiGranuleRecord = { | |||
| timestamp?: number | |||
| timeToArchive?: number | |||
| timeToPreprocess?: number | |||
| } & PartialGranuleTemporalInfo & ParitalGranuleProcessingInfo; | |||
| } & PartialGranuleTemporalInfo & PartialGranuleProcessingInfo; | |||
npauzenga
reviewed
Jan 27, 2025
| if (date === null) return null; | ||
| const convertDateToISOStringSettingNull = (date: string | null | undefined) => { | ||
| if (isNil(date)) return date; | ||
| if (date === '') return null; |
There was a problem hiding this comment.
I think this is good and is more explicit than something like if (!date) but is there a case here where just checking for a falsy value with !date falls down?
npauzenga
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Nice @Jkovarik this looks very reasonable. I added a question about using your explicit checks vs. !date but that's mainly to ensure there's not a case here that needs to be explicitly tested.
Pre-emptively approving because I don't see where this might cause issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds logic in convertDateToISOStringSettingNull to:
This update should be compatible with api granule write logic in that it's preserving the intent of implicit undefined values while allowing for explicit undefineds that weren't originally part of the expected typing coming from the CMR metadata spec.
Summary: Summary of changes
Addresses CUMULUS-3682
Changes
PR Checklist